Make disable on site more prominent#2787
Merged
ghostwords merged 19 commits intomasterfrom Jul 27, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Larger text + shadow to make the button "pop"
Contributor
Author
|
Thanks for these tweaks! I'm definitely in favor of simplifying the report button message as well. That's a keeper. I'm on the fence about the rounded corners for the buttons. On the one hand, it does kinda fall in line with how many other web things style their buttons, so it appeals to that sense of familiarity with people. On the other hand, the curve radius on the button is just different enough from the highlighted blocked resources outlines that it's noticeable and kind of bothersome. I'm not in favor of the drop shadow on the power button, however. I think it's a little visually confusing when you see it, since it's the only thing in the popup that would have that kind of lifted dimension. |
Contributor
Author
f34a677 to
ea5cf91
Compare
Member
ea5cf91 to
4ea6261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related to #2781, #2021. Supersedes #2660.
This makes some more cosmetic changes to the popup to make the disable and enable buttons more prominent.